liquid-labs / liquid-labs/catalyst-core-ui

Simplify BasicContentFrame and friends; improve feedback.

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
0
Forks
0
No merged PRs in 30d

Description

Break this issue up.

  • Instead of passing in a showChildren parameter to AppNavigation, just pass in null to centerChildren.
  • Go back to using AppNavigationProps instead of the various navXxx props. It's less brittle.
  • Have containing component pass in a progess spinner instead of null for the update process (use 'update profile' as test case).
  • Factor out InformativeProgress from Waiter (into mui-extensions) which handles the display of what the waiter is doing. Use it in Waiter, here (and exlpain "Saving...") an the 'Verify email' control.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Split the checklist into separate tasks, then locate BasicContentFrame, AppNavigation, Waiter, InformativeProgress, and the mui-extensions area. Use the “update profile” flow as the stated test case for progress feedback and review the “Verify email” control. Done means each listed prop, progress-display, and extraction change is addressed and the requested “Saving...” explanation is shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.