liquid-labs / liquid-labs/catalyst-core-ui
Properly support 'control style'
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
We want to allow users the ability to select 'text' or 'icon' controls.
- [ ] add 'controlStyle' property to Catalyst Theme. May be 'icon' or 'text'.
- [ ] create 'LabelControl' component to mirror 'IconControl'. Should take the same properties. Note buttons are not fixed width like icons. Alignment controlled by parent component.
- [ ] select component, 'IconControl' or 'LabelControl' based on property, if present, theme setting, if present, and 'icon' by default. Change the label function to take rank and style.
- [ ] pass in rank as a property rather than as structural child.
By adding the property to the theme, we will prep for user choice to select preferences when we implement user-controlled theming.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Catalyst Theme, IconControl, the select component, and the label function named in the checklist. Trace how control selection and rank are currently passed, then implement the requested theme property and LabelControl behavior. Done means text and icon controls can be selected in the stated precedence order and rank is passed as a property.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100