liquid-labs / liquid-labs/bash-rollup

Make sym-link processing optional

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement security
Dominant language
Shell
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Overview

Currently, sym-link files and dirs are traversed just like regular files. This is usually what the user wants, but can be a security concern so we should make them ask for the behavior explicitly.

Deliverables

  • add --follow-symlinks invocation option. If present, then processing behavior is as current.
  • If not present, then remove the -L option from find and test any files found to see if they are symlinks.
  • If a search fails and the --follow-symlinks option was not set, advise the user that --follow-symlinks must be used if any of the target files or valid search directories are symlinks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the command-line option parsing and the search invocation that currently uses find with -L. Trace how failed searches are reported. Done means --follow-symlinks preserves current traversal, while the default avoids symlinks and explains the required option when a target or valid search directory is a symlink.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash, shell
Domain
cli, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.