liquid-labs / liquid-labs/bash-rollup
Make sym-link processing optional
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Overview
Currently, sym-link files and dirs are traversed just like regular files. This is usually what the user wants, but can be a security concern so we should make them ask for the behavior explicitly.
Deliverables
- add
--follow-symlinksinvocation option. If present, then processing behavior is as current. - If not present, then remove the
-Loption from find and test any files found to see if they are symlinks. - If a search fails and the
--follow-symlinksoption was not set, advise the user that--follow-symlinksmust be used if any of the target files or valid search directories are symlinks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the command-line option parsing and the search invocation that currently uses find with -L. Trace how failed searches are reported. Done means --follow-symlinks preserves current traversal, while the default avoids symlinks and explains the required option when a target or valid search directory is a symlink.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, shell
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100