lionleaf / lionleaf/dwitter

Error display messes up the play/pause on scroll mechanism

Open
#389 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
803
Forks
68
PR merge metrics
No merged PRs in 30d

Description

It's more noticeable on shorter/low-res screens. To reproduce the issue you can paste
```javascript
throw '\n'.repeat(33)
```
into a dweet and then scroll down.

I'm guessing Waypoint.Inview can't handle dynamic changes to elements' heights, or it needs to be notified somehow? It seems to reset when more dweets are loaded.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by putting `throw '\n'.repeat(33)` in a dweet and scrolling on a short or low-resolution screen. Start by tracing the play/pause-on-scroll entry point that uses Waypoint.Inview, then verify that controls remain correct after the error changes the element height and after more dweets load.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.