linuxppc / linuxppc/issues

Consolidate cache info parsing / setup

Open
#162 0 comments 0 reactions 1 assignee View on GitHub

@shenki is already working on this.

Since Oct 12, 2018.

bug medium
Dominant language
No language data
Stars
14
Forks
0
PR merge metrics
No merged PRs in 30d

Description

We have to places in the code that look at CPU cache info.

There's the code in `setup_64.c`, `init_cache_info()` etc., which is used to set the `AT_L2_CACHESHAPE` etc. properties. And then the topology related code in `cacheinfo.c`.

These should be consolidated. Probably the `setup_64.c` code should be moved into `cacheinfo.c`, and then the topology code should be updated to use the info it generates.

That will then mean the workaround for bad cache info in `init_cache_info()` will be effective for both the `AT` properties and the sysfs info.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.