Space bar should scroll forward a whole page, not a small step.
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 283
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
Distribution
Mint 22
Package version
4.2.2
Frequency
Always
Bug description
When I press the space bar, it scrolls forward by a small step.
However, I expect it to scroll forward by a whole page, similar to many other programs.
Steps to reproduce
Press space bar while viewing a document.
Expected behavior
The page should scroll forward by a whole page.
Additional information
I think this behaviour was added here: https://github.com/linuxmint/xreader/commit/d170f6e63c2272cc6174b42504416b0b244129f0
And is now perhaps here?
https://github.com/linuxmint/xreader/blob/24f7653b5d4b83b153670deecf8f88563e37c627/libview/ev-view.c#L5773
https://github.com/linuxmint/xreader/blob/24f7653b5d4b83b153670deecf8f88563e37c627/libview/ev-view.c#L5775
It's using GTK_SCROLL_STEP_FORWARD, but I'm wondering if it should be GTK_SCROLL_PAGE_FORWARD.
(Shift+Space scroll backwards a whole page as expected.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in libview/ev-view.c around lines 5773-5775 and review how the space-bar action uses GTK_SCROLL_STEP_FORWARD. Compare it with GTK_SCROLL_PAGE_FORWARD and verify that Space scrolls forward one page while Shift+Space continues to scroll backward one page.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100