Feature Request: Don't invert image color when using invert color
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 283
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
* Xreader version (2.8.3)
* Distribution - (Mint 2.1)
Issue
When using "invert color" for dark mode, the color of images is also inverted. This often makes the images harder to interpret.
Steps to reproduce
Enable "Invert Color" with ctrl-I, view a pdf with images.
Expected behaviour
Text colors should be inverted, but images should remain positive.
Other information
Related to, but not the same as #417 (I think their request has much merit). Both of these would likely work very well together if they can be implemented. For a good example, take the MuPDF based Document Viewer on Android devices, which inverts text, but also has an option to leave images positive.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Ctrl-I "Invert Color" behavior in Xreader while viewing a PDF containing images. Check the rendering path for text and images; done means text colors invert while embedded images remain positive, as described in the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100