linuxmint / linuxmint/xreader

Remove annotation causes Xreader to crash

Open
#507 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
283
Forks
82
PR merge metrics
No merged PRs in 30d

Description

 * Xreader version 2.8.3
 * Distribution - Mint 20.1 Cinnamon

Issue
Xreader crashes if you have the annotation reference selected in the Annotations pane, then try to remove the annotation in the text using the context menu.

Steps to reproduce

  1. Open the attached pdf document. annotations_bug.pdf
  2. Open the sidebar (F9), then select "Annotations". Click on the page number to get the annotations dropdown, then click on the annotation reference.
  3. Use the scroll wheel if necessary to bring the annotation into view. Right-click on it and select "Remove annotation"

RESULT: The App. crashes.

This only happens if you have the annotation reference highlighted in the side pane. If the focus is elsewhere, then the annotation is removed as expected.

Expected behaviour

The annotation should be deleted.

Other information
This bug was originally picked up in "Add remove annotation functionnality" #181.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash with the attached annotations_bug.pdf in Xreader 2.8.3: open the Annotations pane, select the annotation reference, and choose “Remove annotation” from the context menu. Trace the annotation-removal entry point reached from that context menu and verify that the annotation is deleted without crashing when the reference remains selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.