linuxmint / linuxmint/nemo

File conflict dialog mnemonics (Alt-Hotkeys): Replace button missing hotkey, Key S used double conflict

Open
#3,733 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
1.6k
Forks
368
Avg merge
4d 4h
Merged PRs (30d)
2

Description

Distribution

Mint 22.2

Package version

6.4.5

Frequency

Always

Bug description

When I paste a file onto an existing file, a "file conflict" dialog appear.
I like to use my keyboard and Replace is the most used button, but it does not have an Alt-Key assigned.

Also, the Skip Button has Alt-S assigned, which is also assigned to "Select a new name for destination".

So there are two fixes on the same screen.

This looks like a quick fix, probably only

// nemo-file-conflict-dialog.c
// add underscore before R
	details->replace_button =
		gtk_dialog_add_button (dialog,
				       _("_Replace"), 
				       CONFLICT_RESPONSE_REPLACE);
	gtk_widget_grab_focus (details->replace_button);

and

  // move underscore from _Select to _name
	/* Setup the expander for the rename action */
	details->expander = gtk_expander_new_with_mnemonic (_("Select a new _name for the destination"));
	gtk_box_pack_start (GTK_BOX (vbox2), details->expander, FALSE, FALSE, 0);
	g_signal_connect (details->expander, "activate",
			  G_CALLBACK (expander_activated_cb), dialog);
Image
Steps to reproduce
  1. open second pane,
  2. copy a file with the same name over to the other pane
  3. file conflict dialog opens
Expected behavior

All buttons have mnemonics. No duplicate mnemonics.

Additional information

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open nemo-file-conflict-dialog.c and inspect the file-conflict dialog's Replace, Skip, and rename controls. Reproduce the issue by copying a same-named file between panes, then verify that the dialog's keyboard mnemonics are present and unique.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
accessibility, desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.