Nemo 3.6.5: Ctrl-Z during file rename operation undoes last Nemo operation, not current typing

Open
#1,854 9 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
c
Domain
desktop

Research direction

Reproduce the two-file rename sequence in Nemo 3.6.5 and compare Ctrl-Z while the second filename is being edited, including the Desktop case. Trace the rename text-editing and operation-undo handling; done means Ctrl-Z restores the active filename's text without undoing the earlier file operation.

Written by the indexing model from the issue text.

Description

BUG REPRODUCED 
 * Nemo version 3.6.5
 * Is issue with windowed nemo
 * Distribution - Mint 18.3 Cinnamon
 * Graphics hardware *and* driver used: Intel Core i5-6500 (Sky Lake integrated gfx driver)
 * 64 bit

When typing a new filename (e.g. renaming file, or creating a new folder) if a typing error is made, the expectation is that Ctrl-Z will UNDO the typing mistake. Instead, it undoes the last Nemo operation (Rename, Move etc.)

Steps to reproduce

  1. Open a Nemo folder containing 2 or more files.
  2. Rename the first file, by any method preferred.
  3. Start to rename the second file.
  4. While the second filename is still being edited, press Ctrl-Z.

Expected behaviour
5) The expectation is that the filename being edited will revert to its original name (still active for editing)

Other information
6) Instead, file 1 will revert to its original name.

This is inconsistent with the behavior of text editing elsewhere in the environment - for example, in the Text Editor application or the Firefox URL bar. The scope of the Ctrl-Z "undo" operation is expected to be the current text editing operation, not the Nemo file operations history.

NB if the two files are on the Desktop, the behavior is slightly different. Step (4) still undoes step (2), but the filename of file 1 is not visibly reverted (it stays in its apparent renamed state), until I exit from the edit operation on file 2.

My apologies if this is a duplicate issue. I searched the linuxmint/nemo issues list without finding the same issue.

Dominant language
C
Stars
1.6k
Forks
368
Avg merge
4d 4h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxmint/nemo

All issues in linuxmint/nemo

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.