Automatic height limit for popup menu doesn't work

Distribution

Mint 22.3

Package version

6.6.9

Graphics hardware in use

No response

Frequency

Always

Bug description

I'm currently revamping the applet Drawer and have stumbled across the case where the popup menu gets very tall but instead of had been limited and a scrollbar being shown (as documented here), it just renders off screen (there are two more menu items that can't be seen in the screenshot):

Steps to reproduce

1. Clone my repo: https://github.com/s-h-a-d-o-w/show-hide-applets_mohammad-sn
2. git checkout repeat-popup-menu-items (On this branch, icons are intentionally added multiple times, to ensure that anybody trying this hopefully gets above the maximum height.)
3. ./test-spice show-hide-applets@mohammad-sn
4. Move the applet to the right side of your panel, then right click on it for the menu.

Expected behavior

Height of the menu should be limited, a scrollbar should be shown.

Additional information

UPDATE:
I just noticed that you don't seem to run this._applet_context_menu.setMaxHeight(); internally, as the comment that I linked to says. If I call it in my code, I can see that style is actually set to max-height: 1040px; max-width: 1920px;. But it still doesn't result in a scrollbar getting rendered when that is exceeded.

Start in js/ui/popupMenu.js around the documented setMaxHeight() logic, then reproduce the issue with the show-hide-applets repository using the repeat-popup-menu-items branch and ./test-spice. Trace the applet context menu's height and scrollbar behavior; done means an oversized popup is constrained and displays a usable scrollbar without requiring the applet to call setMaxHeight() itself.