linuxmint / linuxmint/cinnamon

Run Dialog Attempts to Execute Escaped File/Directory Paths

Open
#10,517 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5.6k
Forks
915
Avg merge
5d 22h
Merged PRs (30d)
3

Description

 * Cinnamon version: 5.0.7
 * Distribution: Linux Mint 20.2 Uma
 * Graphics Hardware: GeForce GTX 1050 Ti
 * Graphics Driver: nvidia-driver-470 / 470.86-0ubuntu0.20.04.1
 * System Architecture: x86_64

Issue
When using the Run Dialog, tab completion will automatically escape spaces. This is problematic in some cases.

When running a command on a file from the Run Dialog, this is fine, however, when entering just a file/directory path into the Run Dialog, the run dialog allows you to quickly open that path... but if you tab complete, it will escape the spaces, which the Run Dialog will then attempt to execute as a program rather than opening with an appropriate associated program or prompting for the selection of one.

The following is an example where attempting to open a particular folder under ~/Pictures containing a space where tab completion was used.
image

Steps to reproduce

  1. Pull up Run Dialog
  2. Tab Complete a path containing a space
  3. Press The Enter Key

Expected behaviour
If the file is not an executable program with the executable permission, it should instead open with its associated program, such as Nemo or Xed or prompt the user to select an appropriate application.

Cinnamon's Run Dialog can open files with non-escaped spaces normally and should not treat non-executable file paths with escaped spaces differently, especially since it will escape spaces on its own with the tab completion.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Cinnamon Run Dialog entry point and reproduce the issue by tab-completing a path containing spaces, then pressing Enter. Trace how escaped paths are classified and launched. Done means a non-executable file or directory with escaped spaces opens with its associated application or prompts for an application instead of being executed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.