detect_boot_device() prevents OEM factory reset to fully complete
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 1.6k
- Forks
- 211
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 6
Description
(coming from https://github.com/osresearch/heads/issues/1255#issuecomment-1499764982)
This is X230 running `x230-maximized` as of https://github.com/osresearch/heads/pull/1350/commits/3c4b1cc083c962998c90c37f44d4124a42bc3e75
If I have `/dev/sda1` populated with various ISO images, but there is no `/boot/grub`, OEM factory reset will skip:
* generation of a rollback counter
* re-signing of /boot with the new key
After that half-done OEM reset I have to reset TPM again and try to sign my `/boot` files. Apparently `gui-init` and other scripts do not have a problem signing and verifying such "incomplete" `/boot`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at detect_boot_device() and trace the OEM factory-reset path that calls it; the issue does not name specific files or tests. Reproduce with /dev/sda1 containing ISO images and no /boot/grub, then verify that the reset completes both rollback-counter generation and /boot re-signing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100