linuxboot / linuxboot/fiano

NewSignatureData casts crypto.Signer to specific implementations.

Open
#421 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
373
Forks
59
PR merge metrics
No merged PRs in 30d

Description

NewSignatureData casts crypto.Signer interface unnecessarily into specific golang crypto implementations. This prevents the use of other implementations, e.g., for signing with an HSM backed key.

I propose this [1] change to allow for generic crypto.Signer use.

[1] https://github.com/linuxboot/fiano/pull/420

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with NewSignatureData and compare the proposed change in pull request #420. Check how the function handles crypto.Signer implementations, including HSM-backed keys, and verify that generic signers work without relying on specific Go crypto implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.