linuxboot / linuxboot/contest

Feature request: actions on target manager release

Open
#41 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
20
Forks
17
PR merge metrics
No merged PRs in 30d

Description

I would like to do some logging on a target after each test run no matter whether it succeeds or fails.
Currently to do so, I need to implement this logic in ReleaseTargets() method that will be unique for each TargetsManager, while it looks like these actions should be common and shared across all of them.

CC: @tfg13 , @rminnich , @insomniacslk

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the TargetsManager implementations and the ReleaseTargets() method mentioned in the issue. Trace how test-run success and failure are handled, then determine where shared actions belong so logging runs after either outcome. Done means the common behavior works for every target manager without duplicating it in each ReleaseTargets() implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.