Fix license checks for non-go files
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 20
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Thursday Dec 03, 2020 at 21:20 GMT
Originally opened as https://github.com/facebookincubator/contest/issues/192
As noted in https://github.com/facebookincubator/contest/pull/188 our CI doesn't detect correctly when non-go files are missing the copyright header. Specifically, despite adding *.sql to the configuration of checklicenses, it always reports success, even when the license header is missing or wrong.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CI configuration for checklicenses and review the behavior described in pull request 188. Reproduce the check with a missing or incorrect header in a *.sql file, then confirm that CI reports the failure while preserving the existing Go-file checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100