linuxboot / linuxboot/contest

[v2] remove unnecessary json lists from param values

Open
#136 0 comments 0 reactions 1 assignee View on GitHub

@mimir-d is already working on this.

Since Aug 23, 2022.

bug v2_overhaul
Dominant language
Go
Stars
20
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Currently, all of the parameters are expected to be lists, even when it is unnecessary (like the "binary" below).
```json
{
"name": "gathercmd",
"label": "make_logdirs",
"parameters": {
"binary": ["mkdir"], <--
"args": ["-p", "/tmp/control_logs"]
}
}
```

There is also some api supporting this `Param.GetOne`. This should be removed, and the descriptors updated to have single values.
Proposal
```json
{
"name": "gathercmd",
"label": "make_logdirs",
"parameters": {
"binary": "mkdir", <--
"args": ["-p", "/tmp/control_logs"]
}
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.