Move job ID from test.TestResult to the signature of Reporter.Report
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 20
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
_Tuesday Feb 04, 2020 at 16:37 GMT_
_Originally opened as https://github.com/facebookincubator/contest/issues/16_
----
The job ID is unique per reporter, it is redundant to have it in each TestResult of the results array. It also makes it more explicit to the user
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definitions and call sites for test.TestResult and Reporter.Report, then trace how the job ID moves through the reporting path. Done means the job ID is supplied through Reporter.Report rather than duplicated in each TestResult, with the project’s existing tests or build still passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100