MinDevices, MaxDevices and Timeout should be available to every target manager
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 20
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
_Tuesday Feb 04, 2020 at 16:35 GMT_
_Originally opened as https://github.com/facebookincubator/contest/issues/15_
----
This is currently left to plugin implementations, which may or may not require their presence. We also need to reject jobs if no device is returned. The various `Host` and `Device` should become Target (i.e. MinTargets and MaxTargets) to have consistent naming.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review how MinDevices, MaxDevices, Timeout, and the various Host and Device settings are currently defined across target-manager and plugin implementations. Trace job handling to identify where a missing device result should be rejected, then determine the scope of the consistent Target naming. Done means every target manager exposes the required settings and jobs without a returned device are rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100