Detect missing panic recovery in goroutines in plugins
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 20
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
_Tuesday Feb 04, 2020 at 16:25 GMT_
_Originally opened as https://github.com/facebookincubator/contest/issues/5_
----
Panic in goroutines other than the main one cannot be recovered explicitly, they have to be handled in the goroutine itself[1].
For ConTest this means that if a test step or any other plugin has a goroutine that panics, we are not able to catch it.
We should write a tool to detect (statically or dynamically) whether each spawned goroutine attempts to recover, and warn that the plugin may break the service run.
[1] https://stackoverflow.com/questions/50409011/handling-panics-in-go-routines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names plugins and spawned goroutines but does not identify files, tests, or an entry point. First locate where plugin goroutines are created and determine whether static or dynamic detection is intended. Done means warning when a plugin goroutine lacks panic recovery.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100