linux-credentials / linux-credentials/credentialsd
Serialize all D-Bus fields and enum values with snake case
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 259
- Forks
- 19
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 12
Description
We borrow a lot of fields and values from WebAuthn. For internal consistency and consistency with other D-Bus APIs, I think we should convert them to snake_case instead of camelCase, as is more common in JavaScript.
This includes the `publicKey` field of create/get credential requests, `topOrigin` (#81), etc.
This is a breaking change to the API.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the D-Bus API definitions for create/get credential requests and the fields and enum values mentioned here, including publicKey and topOrigin. Review how their serialized names are specified, then verify that every affected field and enum value uses snake_case and that the resulting breaking API change is covered by the project's available checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, authentication
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100