linode / linode/linode-blockstorage-csi-driver
do not return error if requested volume size is the current volume size
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 76
- Forks
- 62
- Avg merge
- 10h 58m
- Merged PRs (30d)
- 10
Description
I have a scenario where I was trying to expand the volume, and was running into some issues on my end, so I end up resizing the volume from the UI manually.
Now in the k8s cluster, it still shows the old size (16Gi), and in the UI it shows the new size (100Gi).
But now when I am trying to persist the change via my ci/cd pipeline, I keep getting error:
```
Warning VolumeResizeFailed 26s (x9 over 33s) external-resizer linodebs.csi.linode.com resize volume "pvc-xxxxxxxxxxx" by resizer "linodebs.csi.linode.com" failed: rpc error: code = Internal desc = resize volume xxxxxxxx: [400] Storage volumes can only be resized up
```
maybe we should not return the error if the expected size and the actual size are same when reconciling [here](https://github.com/linode/linode-blockstorage-csi-driver/blob/f02f10003d7efb81b3ca6755f0df13186ed0abe1/internal/driver/controllerserver.go#L466).
I am happy to submit a PR if this looks like an acceptable request.
thanks in advance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in internal/driver/controllerserver.go around line 466 and trace the volume resize reconciliation path. Confirm how it handles matching requested and current sizes, then verify that reconciliation does not return the reported resize error when both sizes are equal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100