linksplatform / linksplatform/doublets-rs
Use Links trait from data
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6
- Forks
- 0
- Avg merge
- 1h 37m
- Merged PRs (30d)
- 1
Description
At the moment `Doublets` trait use [`Links`](https://github.com/linksplatform/doublets-rs/blob/main/doublets/src/data/traits.rs#L16-L64) trait. This is due to the fact that for a long time `data::Links Error` = `Box`
This is now fixed at https://github.com/linksplatform/data-rs/commit/a2cadfa4744a9eeb28a8f9e6b0ba0e439077667b.
However, `data::Error` still loses information. It may be worth impl `Links for Doublets`, instead of `Doublets for Links`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Links trait in doublets/src/data/traits.rs and trace the current Doublets and Links implementations. Review the referenced data-rs error change, then determine whether the implementation direction can preserve data::Error information; done means the trait relationship and error behavior are covered by the project's relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100