linksplatform / linksplatform/Data

Remove External Zero concept

Open
#120 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
1
Forks
3
PR merge metrics
No merged PRs in 30d

Description

This branch will no longer exist:
https://github.com/linksplatform/Data/blob/a670e099bc97170a317f96ce1015283d2d0b127b/csharp/Platform.Data/Hybrid.cs#L145-L150
No ExternalZero constant anymore:
https://github.com/linksplatform/Data/blob/a670e099bc97170a317f96ce1015283d2d0b127b/csharp/Platform.Data/Hybrid.cs#L41

Regular (internal) zero becomes external.

Pros:
+ Bitwise operations safety
+ Better performance with conversion of raw numbers
+ Zeros in memory managers are now searchable

Cons:
+ Worse performance of memory managers (additional if branches for zero and indexing of zero values)
+ Huge change across the codebase

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with csharp/Platform.Data/Hybrid.cs, especially the ExternalZero constant and branch linked in the issue, then search the codebase for their uses. The change is complete when ExternalZero and its branch are removed, regular zero is treated as external, and affected behavior across the codebase is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.