linksplatform / linksplatform/Data.Doublets
Better argument names in Update()
- Dominant language
- C#
- Stars
- 14
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
The problem:
https://github.com/linksplatform/Data.Doublets/blob/fbf20ca7e110d0faea4f6fe52016f9861b6c6877/csharp/Platform.Data.Doublets/ILinksExtensions.cs#L550
Root of the problem:
https://github.com/linksplatform/Data.Doublets/blob/fbf20ca7e110d0faea4f6fe52016f9861b6c6877/csharp/Platform.Data.Doublets/ILinksExtensions.cs#L623
Currently `source` and `target` are used as selectors, and `newSource` and `newTarget` are the new values for source and target.
In my head `source` and `target` should be used to update source and target values, and the selectors should be named differently.
Possible names:
- `sourceSelector` `targetSelector`
- `sourceFilter` `targetFilter`
- `sourceOld` `targetOld`
- `sourceFind` `targetFind`
- Suggest your own
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect csharp/Platform.Data.Doublets/ILinksExtensions.cs at the referenced lines around Update(). Confirm how source and target are used as selectors and how newSource and newTarget represent replacement values. Choose consistent names for the selector parameters, update their references and callers, and verify the library still builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100