linksplatform / linksplatform/Data.Doublets.Json
Make code more readable
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
- [ ] Move these lines to separate function `SetMarkers`
https://github.com/linksplatform/Data.Doublets.Json/blob/eac0583ca58f992e338352f3e755b4674f479e10/csharp/Platform.Data.Doublets.Json/DefaultJsonStorage.cs#L280-L296
- [ ] Move to separate function `SetMatchers`
https://github.com/linksplatform/Data.Doublets.Json/blob/eac0583ca58f992e338352f3e755b4674f479e10/csharp/Platform.Data.Doublets.Json/DefaultJsonStorage.cs#L298-L299
- [ ] Move to separate function `SetConverters`
https://github.com/linksplatform/Data.Doublets.Json/blob/eac0583ca58f992e338352f3e755b4674f479e10/csharp/Platform.Data.Doublets.Json/DefaultJsonStorage.cs#L309-L316
Note: I have not highlighted all lines you should move. For example there are move converter assign expressions (but in constructor like these) that you must move
put the part of DefaultJsonStorage constructor where markers are assigned to separate function `SetMarkers`. Reason: They are not placed close together
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open csharp/Platform.Data.Doublets.Json/DefaultJsonStorage.cs and inspect the constructor around lines 280-316, including the linked ranges. Trace all marker, matcher, and converter assignments in the constructor, then group them into SetMarkers, SetMatchers, and SetConverters. Done means the constructor delegates these assignments to the three named functions and the project still builds and its tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100