Documentation states that serviceprofile regexes are in golang dialect, but this is not true
Open
@kflynn is already working on this.
Since Aug 2, 2022.
- Dominant language
- JavaScript
- Stars
- 60
- Forks
- 221
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 1
Description
https://linkerd.io/2.10/tasks/getting-per-route-metrics/#troubleshooting
The regex matchers are evaluated by the rust regex engine, not the
golang one, so this troubleshooting advice is incorrect.
As an example of the difference, `[\w-,]` is evaluated differently
between the two.
- In golang, this is a class containing all "word chars" (\w), the
literal `-` and the literal `,`. The hyphen is not considered a
request for a range of chars, because it doesn't make sense to open a
range with a character class.
- In rust, this is an invalid regex, because it doesn't make sense to
open a range with a character class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.