linkerd / linkerd/linkerd2

RUSTSEC-2020-0159: Potential segfault in `localtime_r` invocations

Open
#7,634 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/controller area/security rust
Dominant language
Go
Stars
11.5k
Forks
1.4k
Avg merge
3d 22h
Merged PRs (30d)
53

Description

> Potential segfault in `localtime_r` invocations

| Details | |
| ------------------- | ---------------------------------------------- |
| Package | `chrono` |
| Version | `0.4.19` |
| URL | [https://github.com/chronotope/chrono/issues/499](https://github.com/chronotope/chrono/issues/499) |
| Date | 2020-11-10 |

### Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

### Workarounds

No workarounds are known.

### References

- [time-rs/time#293](https://github.com/time-rs/time/issues/293)

See [advisory page](https://rustsec.org/advisories/RUSTSEC-2020-0159.html) for additional details.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository file, test, or entry point is named. Start by reading the linked RustSec advisory and the referenced chrono and time-rs issues, then inspect how linkerd2 depends on chrono; done means the vulnerable dependency is addressed and the relevant dependency checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.