CI should fail if JS Unit Tests return a warning
Open
@mi-lee is already working on this.
Since Feb 26, 2020.
area/test
- Dominant language
- Go
- Stars
- 11.5k
- Forks
- 1.4k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 53
Description
Some of the JS changes introduced in #3882 made `Navigation.test.jsx` return a warning ([see context](https://github.com/linkerd/linkerd2/pull/3925#pullrequestreview-344310409)) if you ran the unit tests locally with:
```
bin/web setup
bin/web test
```
Because it was a warning and not a test failure, the tests passed CI. Warnings flag possible issues, so we should have CI fail if JS unit tests return a warning.
The test warning was fixed in #3925. To reproduce, run above testing instructions on any commit between #3882 and #3925.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.