Use of kubernetes.io/tls instead of Opaque for Certificates
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 11.5k
- Forks
- 1.4k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 53
Description
## Feature Request
Replace Certificate type to use kubernetes.io/tls for web-hooks and api-service implementation
### What problem are you trying to solve?
To make tls secret consistent with Kubernetes type(kubernetes.io/tls) that facilitates use of cert generators like cert-manager
### How should the problem be solved?
By using tls.key and tls.crt instead of key.pem and crt.pem
```
File: linkerd2/pkg/k8s/labels.go
// IdentityIssuerKeyName is the issuer's private key file.
IdentityIssuerKeyName = "key.pem"
// IdentityIssuerCrtName is the issuer's certificate file.
IdentityIssuerCrtName = "crt.pem"
```
### What do you want to happen? Add any considered drawbacks.
None
### Any alternatives you've considered?
Alternative is to mount tls.key and tls.crt as subpath that maps to key.pem and crt.pem. Though doable, it is cumbersome.
### How would users interact with this feature?
No direct user impact.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in linkerd2/pkg/k8s/labels.go, then search for uses of IdentityIssuerKeyName and IdentityIssuerCrtName in the webhook and API-service implementations. Update the certificate key names to the Kubernetes TLS names and verify that those consumers use tls.key and tls.crt consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100