linkerd / linkerd/linkerd2

[Feature] Mutating webhook for ingress annotations

Open
#3,738 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/controller help wanted priority/P1
Dominant language
Go
Stars
11.5k
Forks
1.4k
Avg merge
3d 22h
Merged PRs (30d)
53

Description

## Feature Request
A webhook or extension of the existing injector that will annotate ingresses automatically.

### What problem are you trying to solve?
Having to manually add annotations to every ingress object.

### How should the problem be solved?

I'm thinking a mutating webhook that will accept some configuration on install such that any ingress created within a namespace that is annotated for sidecar injection will get the necessary config annotations. A couple of things will be required:

* Some sort of configuration that specifies what type of controller, or some detection of controller type based on ingress annotations
* Possible that exclusion annotations might be necessary
* The ability to turn on/off the injector

What do you want to happen? Add any considered drawbacks.

### Any alternatives you've considered?

Is there another way to solve this problem that isn't as good a solution?

* An external mutating webhook controller

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the existing injector and Kubernetes mutating-webhook path first; no specific file or test is named in the issue. A completed proposal should define install-time configuration, controller detection, exclusion and enable/disable behavior, with tests covering which ingress objects receive annotations.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.