linkerd / linkerd/linkerd2

Provide new mechanism for injected container configuration

Open
#2,129 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/cli area/inject rfc
Dominant language
Go
Stars
11.5k
Forks
1.4k
Avg merge
3d 22h
Merged PRs (30d)
53

Description

## Feature Request

### What problem are you trying to solve?

As the Kubernetes container spec evolves, there will be new options for configuring the linkerd-proxy and linkerd-init containers that are added when running `linkerd inject`. Rather than adding new CLI flags for for every possible container configuration, we need a better way for users to modify the injected YAML. This will allow them to configure things like resource requests/ resource limits / readiness probes / liveliness probes without an explosion of CLI flags.

### How should the problem be solved?

From the comments on #2001, it seems like we could instruct users to use [kustomize](https://github.com/kubernetes-sigs/kustomize) or some similar tool to modify the YAML post-inject.

### Any alternatives you've considered?

A CLI flag for every field in the [Kubernetes container spec](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#container-v1-core) 🙀

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the `linkerd inject` entry point and review the discussion in #2001, along with the Kubernetes container spec referenced in the issue. Determine how users could modify injected YAML for proxy and init-container settings without adding a flag for every field. Done should provide a supported mechanism for those post-injection changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
cli, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.