linkerd / linkerd/linkerd2

Telemetry for Upgrades and CONNECT

Open
#1,206 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

area/proxy area/telemetry rfc
Dominant language
Go
Stars
11.5k
Forks
1.4k
Avg merge
3d 22h
Merged PRs (30d)
53

Description

We now support both HTTP Upgrades (#1126) and CONNECT (#1200). They both make use of the HTTP sensors while the requests look like HTTP/1, and once the upgrade is complete, they convert into TCP proxies. That means no more HTTP sensors are used, but the transport sensors are still in place.

However, these are both probably significant enough to warrant emitting special events in our telemetry, so that users can see successful (and failed) HTTP Upgrades / CONNECT. Or maybe just Upgrades are sufficiently important.

A related question is whether something should be exposed in TAP.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the HTTP sensors and transport sensors used by HTTP Upgrades and CONNECT, then review how telemetry events and TAP exposure are currently defined. Clarify whether both successful and failed Upgrades and CONNECT require events, and define the telemetry and TAP behavior before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.