linkerd / linkerd/linkerd-zipkin
Add support for scribe transport
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 29
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
The intial telemeters provided are http and kafka. For consistency with [zipkin-finagle](https://github.com/openzipkin/zipkin-finagle), we should consider adding scribe as well.
Adding a dependency on zipkin-finagle's scribe module, however, causes a version conflict with libthrift. To reproduce, first add the dependency:
```
diff --git a/build.sbt b/build.sbt
index acead10..264d03b 100644
--- a/build.sbt
+++ b/build.sbt
@@ -33,6 +33,7 @@ val `linkerd-zipkin` =
twitterUtil("stats"),
zipkin("http"),
zipkin("kafka"),
+ zipkin("scribe"),
scalatest() % "test"
),
aggregate in assembly := false,
```
And then run `./sbt assembly`. That produces a bunch of errors of the format:
```
[error] (*:assembly) deduplicate: different file contents found in the following:
[error] /Users/kl/.ivy2/cache/com.twitter/libthrift/jars/libthrift-0.5.0-7.jar:org/apache/thrift/EncodingUtils.class
[error] /Users/kl/.ivy2/cache/org.apache.thrift/libthrift/jars/libthrift-0.9.3.jar:org/apache/thrift/EncodingUtils.class
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in build.sbt by reproducing the added zipkin("scribe") dependency, then run ./sbt assembly to inspect the libthrift 0.5.0-7 and 0.9.3 duplicate-class errors. Done means scribe transport support can be added without the libthrift assembly conflict.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100