linkedin / linkedin/venice

[Feature] Allow pass-through Kafka config in samza VeniceSystemProducer

Open
#653 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
611
Forks
124
Avg merge
3d 1h
Merged PRs (30d)
26

Description

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feature Request Proposal

Currently, the Kafka producer config in VeniceWriter being used by Samza VeniceSystemProducer is not tunable since Kafka config pass through is not supported.

Motivation
What is the use case for this feature?

Enabling pass through of configs would enable us to keep up with new tunable parameters we'd like to adopt into the producer. As it stands today, we have to cut code in order to add new parameters. So it'd be ideal to club all future N birds with this stone.

Details

No response

What component(s) does this bug affect?
  • Controller: This is the control-plane for Venice. Used to create/update/query stores and their metadata.
  • Router: This is the stateless query-routing layer for serving read requests.
  • Server: This is the component that persists all the store data.
  • VenicePushJob: This is the component that pushes derived data from Hadoop to Venice backend.
  • VenicePulsarSink: This is a Sink connector for Apache Pulsar that pushes data from Pulsar into Venice.
  • Thin Client: This is a stateless client users use to query Venice Router for reading store data.
  • Fast Client: This is a stateful client users use to query Venice Server for reading store data.
  • Da Vinci Client: This is an embedded, stateful client that materializes store data locally.
  • Samza: This is the library users use to make nearline updates to store data.
  • Admin Tool: This is the stand-alone client used for ad-hoc operations on Venice.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Samza's VeniceSystemProducer and trace how its VeniceWriter Kafka producer configuration is assembled. Determine how configuration pass-through should be exposed and verify that new Kafka producer parameters can be supplied without a code change for each parameter.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kafka
Domain
backend, stream-processing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.