linkedin / linkedin/spark-tfrecord
Support for ShortType, ByteType
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 300
- Forks
- 57
- PR merge metrics
- No merged PRs in 30d
Description
Hi @junshi15 ,
I was wondering if I could put in a request to support ShortType and ByteType? I'm getting errors like `Cannot convert field to unsupported data type ShortType` which I believe is coming from https://github.com/linkedin/spark-tfrecord/blob/master/src/main/scala/com/linkedin/spark/datasources/tfrecord/TFRecordSerializer.scala
Thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/main/scala/com/linkedin/spark/datasources/tfrecord/TFRecordSerializer.scala, especially the handling that reports unsupported data types. Trace how ShortType and ByteType are converted and check the existing project tests for serializer coverage. Done means both types are accepted when writing TFRecord data without the reported unsupported-type error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala, spark, tensorflow
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100