linkedin / linkedin/shiv

Make shivs output a little more informative

Open
#42 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
114
PR merge metrics
No merged PRs in 30d

Description

Just a couple of things that could make the usage experience a little better ;

  • Confirmation that an output file was written. ie generated pyz to <output_file> or similar
  • Flagging of success vs some error condition. I was getting an error for a while - but wasn't entirely sure if it was just a warning - since the last output line is just "done".

If there is agreement that this would be useful I'm happy to put a quick PR together.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file, test, or CLI entry point. Start by reproducing a successful build and an error, then trace where the final "done" output is produced. Done means clearly reporting the output file path and distinguishing successful completion from an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.