linkedin / linkedin/shiv

The shiv of release page should probably be generated on Windows

Open
#233 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
114
PR merge metrics
No merged PRs in 30d

Description

I downloaded shiv v1.03 from the release page, and when I tried to run it, it didn't work as expected.

PS D:\> py -3.9 ./shiv -h
Traceback (most recent call last):
  File "D:\Program Files\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Program Files\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
.
.
.
  File "C:\Users\Toor\.shiv\shiv_1c0a7a05e4af1a79fd343dde784c153c0929af743f4412922
abd6ce5dbfb620d\site-packages\click\_compat.py", line 541, in auto_wrap_for_ansi
    import colorama
ModuleNotFoundError: No module named 'colorama'

According to the traceback message, I found that the click has additional dependencies on Windows.

It appears that the shiv was generated on Linux, so the builder did not install colorama.

Then I installed shiv from pip and generated a new shiv, and this time it worked fine.

There may be other users like me who have downloaded it and want to run it to see how it works.

So I think the shiv of the release page should be generated on Windows.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the release-page shiv v1.03 artifact and reproduce the reported Windows command, py -3.9 ./shiv -h, to confirm the missing colorama failure. Compare it with a shiv generated from pip, then verify that the release artifact runs successfully on Windows without that error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.