linkedin / linkedin/shiv

Accept pipenv's Pipfile.lock in place of pip's requirements.txt

Open
#219 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
114
PR merge metrics
No merged PRs in 30d

Description

When running **shiv** to build an app file, a good way to include all the other packages your app depends on seems to be to pass in the option, `-r requirements.txt`. The `requirements.txt` file is managed by **pip**. But I use [`pipenv`](https://pipenv.pypa.io/en/latest/) in preference to **pip**. **Pipenv** lists dependencies in a file named [`Pipfile.lock`](https://pipenv.pypa.io/en/latest/basics/#example-pipfile-pipfile-lock).

I would like to have **shiv** accept `Pipfile.lock` in place of `requirements.txt` as a way to list all the packages which **shiv** should install into the app file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing shiv's command-line handling of the -r requirements.txt option and how that file is passed to dependency installation. Compare the expected Pipfile.lock format with requirements.txt, then verify that a Pipfile.lock can supply the packages used to build the app file.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.