linkedin / linkedin/shaky-android

Dialog button text color is not visible

Open
#60 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
162
Forks
58
PR merge metrics
No merged PRs in 30d

Description

Hey, im trying to use this library, but the values you are using are conflicting with my app theme and i cant find a way to change the color.
image

Im using dayNight material theme, these values im overriding in order to fix it:

    <item name="alertDialogTheme">@style/AlertDialog</item>
    <item name="shakyPopupButtonColor">@color/purple_70</item>
     <item name="shakyAlertDialogTheme">@style/AlertDialog</item>
     <item name="shakyTitleColor">@color/text_main</item>
     <item name="shakyContentColor">@color/text_subtitle</item>
      <item name="android:textColor">@color/purple_70</item>
      
     <style name="AlertDialog" parent="ThemeOverlay.MaterialComponents.Dialog.Alert">
        <item name="colorAccent">@color/purple_70</item>
        <item name="buttonBarNegativeButtonStyle">@style/Widget.Dialog.NegativeButton</item>
        <item name="buttonBarPositiveButtonStyle">@style/Widget.Dialog.PositiveButton</item>
    </style>

  <style name="Widget.Dialog.NegativeButton" parent="Widget.MaterialComponents.Button.TextButton.Dialog">
        <item name="android:textColor">@color/purple_70</item>
    </style>

    <style name="Widget.Dialog.PositiveButton" parent="Widget.MaterialComponents.Button.TextButton.Dialog">
        <item name="android:textColor">@color/purple_70</item>
    </style>

Is there a way to fix it? I cant find any configuration thats working,

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with issue #60 and reproduce the dialog under a dayNight Material theme using the provided style overrides. Trace the library's dialog and button styling entry point, then verify that the button text remains visible without app-specific overrides.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.