Exported component not found because of code logic
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.4k
- Forks
- 663
- PR merge metrics
- No merged PRs in 30d
Description
When I scan a apk with such AndroidManifest.xml:
```xml
```
The issue **Exported tags** is not found in the report.
I check the code and add some print codes, finally found that the problem is in [exported_tags.py:247](https://github.com/linkedin/qark/blob/master/qark/plugins/manifest/exported_tags.py)
```python
if (exported is not None and exported != "false") or tag_is_provider:
print("tag_is_provider:", tag_is_provider) #print tag_is_provider code
print(self.min_sdk) #print min_sdk code
print(self.target_sdk) #print target_sdk code
if tag_is_provider and self.min_sdk > 16 or self.target_sdk > 16:
# provider is not vulnerable under these conditions, return
print('provider is not vulnerable under these conditions, return') #my check code
return
```
and the output is these:
> tag_is_provider: False
29
29
provider is not vulnerable under these conditions, return
>
Please confirm the logic of this code is correct.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in qark/plugins/manifest/exported_tags.py at the condition around line 247, then reproduce the report with the AndroidManifest.xml service example from the issue. Check how the min_sdk, target_sdk, and tag_is_provider values affect the branch, and confirm that the exported service is reported when appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100