linkedin / linkedin/qark

API_KEY check from plugins.manifest.api_keys.py is too permissive

Open
#207 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Python
Stars
3.4k
Forks
663
PR merge metrics
No merged PRs in 30d

Description

Just testing with `test_androidmanifest.xml` gives me back 2 invalid results on things that do not resemble API keys. The regex should be changed to something that correctly resembles an API key.

Discovered in #206

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in plugins.manifest.api_keys.py and reproduce the report using test_androidmanifest.xml. Define the expected API-key shape from the surrounding plugin behavior, then verify that the two false positives are no longer reported while genuine keys remain detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.