linkedin / linkedin/photon-ml

'model-metadata.json' not saved in GCS

Open
#437 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Terra
Stars
795
Forks
175
PR merge metrics
No merged PRs in 30d

Description

The 'model-metadata.json' file is not saved in GCS after a full GAME run.

[Here](https://github.com/linkedin/photon-ml/blob/049dfa8736ec7db58bc815f95d1de547ecdbf8fb/photon-client/src/main/scala/com/linkedin/photon/ml/data/avro/ModelProcessingUtils.scala#L498) is the code that runs it.

This prevents from doing warm-start training as the prior run's file is needed.

Please fix. Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in photon-client/src/main/scala/com/linkedin/photon/ml/data/avro/ModelProcessingUtils.scala around line 498, where the issue links to the metadata-saving code. Reproduce a full GAME run and inspect GCS output; done means model-metadata.json is saved and available for warm-start training.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, scala, spark
Domain
cloud, machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.