linkedin / linkedin/photon-ml

Use mean loss instead of sum loss in Game [backward incompatible]

Open
#252 0 comments 0 reactions 1 assignee View on GitHub

@fastier-li is already working on this.

Since Mar 15, 2017.

Dominant language
Terra
Stars
795
Forks
175
PR merge metrics
No merged PRs in 30d

Description

While comparing spark.ml and scikit, we realized that Game is using a sum in the loss function computation, but that is not desirable for scaling and numerical stability. We should change our loss function calculations to use a mean instead.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.