linkedin / linkedin/photon-ml

Break up and simplify the `optimize` function in CoordinateDescent

Open
#224 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Terra
Stars
795
Forks
175
PR merge metrics
No merged PRs in 30d

Description

The optimize function is very long, complicated, and hard to follow. We should do two things:

  • Break it up into smaller functions
  • Add documentation

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CoordinateDescent class and its optimize function in the Photon-ML source. Read the surrounding implementation to identify coherent responsibilities, then split the function into smaller documented functions while preserving its behavior; done means the function is easier to follow and the requested documentation is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
spark
Domain
machine-learning
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.