Add normalization to HessianDiagonalAggregator
Open
@fastier-li is already working on this.
Since Mar 16, 2017.
- Dominant language
- Terra
- Stars
- 795
- Forks
- 175
- PR merge metrics
- No merged PRs in 30d
Description
From a comment by @XianXing on PR #131:
"The computation and approximation for Hessian diagonal was designed and implemented independent of Photon's normalization, because previously we didn't enable normalization for GLMix.
But it will be helpful if we take the normalization into account as well here for Hessian diagonal, in order to make it consistent with the rest of code."
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.