Proper logging for `withSafeSideEffect`
- Dominant language
- Java
- Stars
- 1.2k
- Forks
- 268
- PR merge metrics
- No merged PRs in 30d
Description
In the below snippet, there's only try...catch logic to convert it to a failed task: https://github.com/linkedin/parseq/blob/74875ed2aa5deaaf5bf1ab822c2fe719039b4aa2/subprojects/parseq/src/main/java/com/linkedin/parseq/Task.java#L398-L408
However, it is hard to add logging on the caller side for this. Thus, the side effect may fail silently without an easy way to debug.
Could we use the LOGGER in this file to log the Throwable before line 407?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in subprojects/parseq/src/main/java/com/linkedin/parseq/Task.java around lines 398-408 and inspect how LOGGER is used in that file. Confirm how withSafeSideEffect converts the Throwable, then ensure the Throwable is logged before that conversion without changing the failed-task behavior. Done means side-effect failures produce an accessible log entry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100