linkedin / linkedin/opticss

An in-range update of codemirror is breaking the build 🚨

Open
#56 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

greenkeeper
Dominant language
TypeScript
Stars
713
Forks
23
PR merge metrics
No merged PRs in 30d

Description

## The dependency [codemirror](https://github.com/codemirror/CodeMirror) was updated from `5.47.0` to `5.48.0`.

🚨 [View failing branch](https://github.com/linkedin/opticss/compare/master...linkedin:greenkeeper%2Fdefault%2Fcodemirror-5.48.0).

This version is **covered** by your **current version range** and after updating it in your project **the build failed**.

codemirror is a direct dependency of this project, and **it is very likely causing it to break**. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

- ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/linkedin/opticss/builds/548072057?utm_source=github_status&utm_medium=notification)).

---

Commits

The new version differs by 16 commits.



  • 908e9da [real-world uses] Fixed link to GWT wrapper extension

  • f249e9d [real-world uses] Added Coderba GWT wrapper

  • 82d1245 [javascript mode] Fix typescript [key in ...] syntax (again)

  • 306c38e [javascript mode] Remove strange handling of 'in' in TypeScript mode

  • 11786d2 [hint addon] Handle scrolling containers

  • 5294bf1 [vim] throttle highlightSearchMatches

  • 3446b79 [real-world uses] Add LiveUML

  • a423203 [groovy mode] Add comment metadata

  • 7978b40 Add selectLeft/selectRight marker options

  • 7886f7f [mode metadata[ Add meta entry for PostgreSQ

  • e31bc36 [clike mode] Remove 'float' as Java keyword

  • 58df150 Also add u+fff9-u+fffb as special characters

  • 8aa23d7 Add U+FFFC as a default replaced special character

  • db1d66c [merge addon] Fix typo in hasMarker()

  • 48561a6 [mode metadata] Add "cs" as alias for C#


There are 16 commits in total.


See the full diff

FAQ and help

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

---

Your [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing branch linked in the issue and inspect the Travis CI build details to identify the failure introduced by codemirror 5.48.0. Compare the dependency update with the project’s current build behavior; done means the build passes with the supported codemirror version.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.