linkedin / linkedin/oncall

make test not working

Open
#318 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.3k
Forks
245
PR merge metrics
No merged PRs in 30d

Description

platform linux2 -- Python 2.7.16, pytest-4.6.10, py-1.8.1, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/vcacadmin/oncall-master
plugins: mock-2.0.0
collected 11 items / 1 errors / 10 selected

========================================================================================================================================== ERRORS ===========================================================================================================================================
____________________________________________________________________________________________________________________________ ERROR collecting test/test_auth.py _____________________________________________________________________________________________________________________________
ImportError while importing test module '/home/vcacadmin/oncall-master/test/test_auth.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/test_auth.py:2: in
from oncall.app import ReqBodyMiddleware
src/oncall/app.py:3: in
from urllib.parse import unquote_plus
E ImportError: No module named parse
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
================================================================================================================================== 1 error in 0.37 seconds ==================================================================================================================================
make[1]: *** [Makefile:7: unit] Error 2
make[1]: Leaving directory '/home/vcacadmin/oncall-master'
make: *** [Makefile:13: test] Error 2
vcacadmin@caoncall:~/oncall-master$

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing import in src/oncall/app.py and the test module test/test_auth.py, then run the Makefile test target under the reported Python and pytest versions. Confirm the cause of test collection failure and verify that the full test command completes successfully without the ImportError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.