linkedin / linkedin/oncall

Make Oncall vendor agnostic, but more modular

Open
#250 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.3k
Forks
245
PR merge metrics
No merged PRs in 30d

Description

Currently there are a handful of vendor modules included in the project and each one is referred to by name (See multiple instances of "Slack" throughout the Oncall / Iris tools). I've already began work on removing all instances of "Slack" from the tools, instead replacing the references with "Chat" (The Teams 'Slack Channel' is now 'Chat Override', this can be the teams slack channel, MS Teams Webhook, etc). That being said, I'm running into a bit of trouble with implementing an MS Teams Vendor (The Iris/src/vendors/__init__py doesn't like the mode name 'chat').

If, by default, Oncall and Iris were more modular (Aka, make a portion of the config set the preferred vendors for Chat, SMS, Call, E-mail, etc. and it would select the appropriate vendor script.)

Vendors:
Call: twillio
SMS: twilio
E-mail: smtp
Chat: teams

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Iris/src/vendors/__init__py and the Oncall/Iris vendor references where Slack is named. Trace how vendor modes are selected from configuration, then define completion as configurable Chat, SMS, Call, and E-mail vendors that can include Teams without hard-coded Slack references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.